search

internetarchive / iaux-search-service

GNU Affero General Public License v3.0
4 stars 2 forks source link

WEBDEV-5842 Add `collectionTitles` property to match new PPS responses #33

Closed latonv closed 1 year ago

latonv commented 1 year ago

This PR adds a collectionTitles property to SearchResponseDetails objects, which optionally contains any collection titles object found on the response. The PPS has recently been upgraded to include such an object on hits/aggregations requests, containing a mapping from any collection identifiers to their readable titles.

github-actions[bot] commented 1 year ago

PR Preview Action v1.2.0 :---: Preview removed because the pull request was closed. 2023-02-13 23:12 UTC

codecov[bot] commented 1 year ago

Codecov Report

Merging #33 (bfa87d3) into main (5f54ef1) will increase coverage by 0.41%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   86.73%   87.15%   +0.41%     
==========================================
  Files          26       26              
  Lines        2511     2522      +11     
  Branches      122      124       +2     
==========================================
+ Hits         2178     2198      +20     
+ Misses        321      313       -8     
+ Partials       12       11       -1
Impacted Files Coverage Δ
src/responses/search-response-details.ts 94.59% <100.00%> (+9.59%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.