search

internetarchive / iaux-search-service

GNU Affero General Public License v3.0
4 stars 2 forks source link

WEBDEV-6081 Extend models for profile pages #48

Closed latonv closed 9 months ago

latonv commented 11 months ago

This MR equips the search service with several new models to handle profile page requests & responses from the PPS. In particular, clients can now request specific page_elements, corresponding roughly to tabs on the profile page. The responses can now accordingly include their main content on a page_elements branch whose shape is determined in part by the type of page element being returned.

This necessarily includes some additional refactoring to cleanly handle what are now multiple page-element-specific means by which search hits must be processed to provide the caller with as consistent an output as possible.

github-actions[bot] commented 11 months ago

PR Preview Action v1.4.6 :---: Preview removed because the pull request was closed. 2024-01-25 03:15 UTC

codecov[bot] commented 10 months ago

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (7cad26c) 91.40% compared to head (fea99f6) 92.27%.

Files Patch % Lines
src/models/hit-types/web-archive-hit.ts 79.03% 13 Missing :warning:
src/responses/search-response-details.ts 97.04% 5 Missing :warning:
src/models/hit-types/item-hit.ts 91.30% 2 Missing :warning:
src/responses/page-elements.ts 99.34% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #48 +/- ## ========================================== + Coverage 91.40% 92.27% +0.87% ========================================== Files 27 29 +2 Lines 2688 3095 +407 Branches 235 271 +36 ========================================== + Hits 2457 2856 +399 - Misses 220 230 +10 + Partials 11 9 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.