Replace usage of `assert` with `expect` assertion library in unit tests

internetarchive / iaux

Monorepo for Archive.org UX development and prototyping.

GNU Affero General Public License v3.0

65 stars 86 forks source link

Replace usage of `assert` with `expect` assertion library in unit tests #242

Open shaneriley opened 5 years ago

shaneriley commented 5 years ago

In the interest of creating a universal guide for testing in all IA projects, we should replace any usage of the assert library with Jest's built in expect library of matchers.

iisa commented 4 years ago

Currently, the only file left with assert is example.test.js

Acceptance criteria:

[ ] swap out assert in example.test.js to expect
[ ] test successfully runs
[ ] remove assert from package.json

kimuradev commented 4 years ago

@iisa I will work on this ;)

anishagg17 commented 4 years ago

@iisa i think this issue is closed now

nektro commented 3 years ago

@iisa would you be able to close this issue if this is resolved since the PR was merged?