search

internetarchive / iiif

The official Internet Archive IIIF service
GNU General Public License v3.0
21 stars 4 forks source link

Broken v2 example #27

Closed glenrobson closed 10 months ago

glenrobson commented 11 months ago

This isn't working:

https://iiif.archive.org/iiif/2/z-2-2-18-14-9/manifest.json

even on the new branch. Version 3 does work OK:

https://iiif.archive.org/iiif/3/z-2-2-18-14-9/manifest.json

The v2 version is thrown a 404 not found and no errors in the logs.

hadro commented 11 months ago

Fwiw, it didn't/doesn't work on the original archivelab instance either: https://iiif.archivelab.org/iiif/z-2-2-18-14-9/manifest.json

glenrobson commented 10 months ago

Seems an issue with the bookreader XML:

http://ia800505.us.archive.org/BookReader/BookReaderJSON.php?server=ia800505.us.archive.org&itemPath=/22/items/z-2-2-18-14-9&itemId=z-2-2-18-14-9

glenrobson commented 10 months ago

Check v3 book reader URL.

hadro commented 10 months ago

This occurred to me in the shower this AM, but is it possible it has something to do with the issue we solved here? https://github.com/ArchiveLabs/iiif.archivelab.org/issues/120

glenrobson commented 10 months ago

V2 book reader URL:

http://ia800505.us.archive.org/BookReader/BookReaderJSON.php?server=ia800505.us.archive.org&itemPath=/22/items/z-2-2-18-14-9&itemId=z-2-2-18-14-9

V3 book reader URL: https://ia800505.us.archive.org/BookReader/BookReaderJSIA.php?id=z-2-2-18-14-9&itemPath=/22/items/z-2-2-18-14-9&server=ia800505.us.archive.org&format=jsonp&subPrefix=z-2-2-18-14-9

So they call different URLs. It looks like the v3 one returns an error which is caught and converts it to a single image:

if 'error' in bookreader:
            # Image stack not found. Maybe a single image
            singleImage(metadata, identifier, manifest, uri)