search

internetarchive / iiif

The official Internet Archive IIIF service
GNU General Public License v3.0
21 stars 4 forks source link

Fix pageorder #31

Closed hadro closed 8 months ago

hadro commented 9 months ago

This fixes #9, but should be merged in after #22

glenrobson commented 9 months ago

It looks like the tests are failing. Is this due to a fix required in #22 before you can get the /iiif/3/rbmsbk_ap2-v4_2001_V55N4/manifest.json manifest?

glenrobson commented 9 months ago

Although its working in the public version:

https://iiif.archive.org//iiif/3/rbmsbk_ap2-v4_2001_V55N4/manifest.json

hadro commented 9 months ago

That's the wrong test, it's the next one that is throwing the error (test_page_behavior_r_to_l, not test_page_behavior), and that manifest currently throws an error on the live site: https://iiif.archive.org/iiif/nybc314063/manifest.json

And yes, that is one of the bugs that will be fixed by #22, it's the issue described in #14

So once #22 is ready to go, this can go ahead assuming you think it's all fine