fix english for some speeches

hyzhak commented 5 years ago

[x] fallback handler drop "but I can help you to find music records and play it."
[ ] ~"Lets play Jazz music” -> "Lets Jam to some Jazz" (for 'jazz' genre only)~ https://github.com/internetarchive/internet-archive-google-action/issues/432
[x] for Live Concerts don't say "Albums". Say "Concerts"
[x] for georgeblood we should rename {{N}} albums to {{N}} songs, because sometimes we could get double sided 78s discs we would give incorrect number of songs.
[ ] [!] and we still need to figure out how to name IA items for both live and 78s - skipped this for simplicity
[x] records -> songs (example: I'v got twelve thirty five Christmas records, lets listen to them) 🎅

knrt10 commented 5 years ago

@hyzhak I would like to work on this issue. I am new to this repo, would you please guide me which files should I look into?

hyzhak commented 5 years ago

@knrt10 thank! here they are https://github.com/internetarchive/internet-archive-google-action/blob/master/functions/src/strings.js

yagyanshbhatia commented 5 years ago

Hey @knrt10 are you still on this issue? I want to work on this, @hyzhak can you please assign me this issue? and please add me to slack group of internet archive, please?

knrt10 commented 5 years ago

Thanks @yagyanshbhatia. I am currently busy, you are free to make a PR for the same.

internetarchive / internet-archive-voice-apps

fix english for some speeches #389