Enumerate all possible errors - Githubissues

internetarchive / liveweb

Liveweb proxy of the Wayback Machine project

https://web.archive.org/

44 stars 13 forks source link

Enumerate all possible errors #30

Closed anandology closed 12 years ago

anandology commented 12 years ago

Enumerate all possible errors that can happen and handle them.

1x - Bad input

Error 10 - Bad URL

2x - DNS errors

Error 20 - Invalid domain name
Error 21 - timeout when resolving the DNS

3x - Connection errors

Error 30 - connection refused
Error 31 - connection dropped abruptly

4x - timeouts

Error 40 - timeout when trying to connect
Error 41 - timeout when reading headers
Error 42 - timeout when reading body

5x - resource limits

Error 50 - Response too big
Error 51 - Response took too long time

Notes

We don't have a way to identify Error 21 as socket.gethostbyname does't respect timeouts
Error 51 is different from timeout. It can happen that the server is giving data at very slow pace (one byte per second) without timing out. This error happens when the total time to read the response cross a pre-defined threshold.

Can you think of any other possible errors?

anandology commented 12 years ago

Reorganized the error codes after discussing with @nibrahim.

http://liveweb.readthedocs.org/en/latest/errors.html

The current error codes looks quite good now.