search

internetarchive / openlibrary

One webpage for every book ever published!
https://openlibrary.org
GNU Affero General Public License v3.0
5.16k stars 1.35k forks source link

Correct how bookreviews CSS is loaded #1262

Closed jdlrobson closed 5 years ago

jdlrobson commented 6 years ago

@weatherwaxed found this file while working on #1261: openlibrary/plugins/bookrev/files/css/bookreviews.css

I see 2 possible (but possibly broken) usages:

openlibrary/plugins/bookrev/templates/addreview.html
6:$add_stylesheet('/static/css/bookreviews.css')

openlibrary/plugins/bookrev/templates/type/bookreview/view.html
6:$add_stylesheet('/static/css/bookreviews.css')

Are these working?

We should move openlibrary/plugins/bookrev/files/css/bookreviews.css into static/css/ if they are legitimate entry points as right now this file is hidden away. A new file page-book-reviews.css should be added that loads the css needed.

If the file is not needed we should remove it and all references to it.

SohanTirpude commented 6 years ago

@jdlrobson apart from moving bookreview.css, what do you mean by "if it's broken we should also fix this"?

jdlrobson commented 6 years ago

Does the edit help?

usmanmuhd commented 6 years ago

@jdlrobson Shall I take this up?

jdlrobson commented 6 years ago

Go for it!

jdlrobson commented 5 years ago

@usmanmuhd are you still interested in working on this? If so anything I can help with?

usmanmuhd commented 5 years ago

Yeah, I wasn't able to setup the docker still.

jdlrobson commented 5 years ago

@usmanmuhd would love to help. Which bit of https://github.com/internetarchive/openlibrary/blob/master/docker/README.md do you get stuck on?

usmanmuhd commented 5 years ago

I was getting ip not found error during setting up docker 91.189.88.152 and when i changed the network and ran again it gave hash mismatch error.

cdrini commented 5 years ago

@usmanmuhd could you create a new issue? Be sure to include your OS, version of docker, what commands you ran, and the output you got back.

jdlrobson commented 5 years ago

@mekarpeles are book reviews in production?

If not I'd love to see openlibrary/plugins/bookrev/code.py and all associated code removed while we tame this codebase and build some better foundations to build on top of.