Add test-cafe tests - Githubissues

internetarchive / openlibrary

One webpage for every book ever published!

https://openlibrary.org

GNU Affero General Public License v3.0

5.16k stars 1.35k forks source link

Add test-cafe tests #3412

Open cdrini opened 4 years ago

cdrini commented 4 years ago

Right now, we don't have any tests that actually run the service (i.e. docker-compose up -d). Test-cafe seems like a good way to get this, as well as some more in depth front-end tests :+1:

Describe the problem that you'd like solved

~Travis~ GitHub Actions should error if docker-compose up -d would error
A framework for adding e2e tests that gets run every time we push to Travis

Proposal & Constraints

It might cause ~Travis~ GitHub Actions to become very slow if it has to run docker :/ Might need to try to find a clever way to make it more performant.

Additional context

Here's the testcafe-travis config we used in bookreader: https://github.com/internetarchive/bookreader/blob/master/.travis.yml

Stakeholders

@mekarpeles @jdlrobson

cclauss commented 4 years ago

https://devexpress.github.io/testcafe/documentation/continuous-integration/travis.html Why do we need Docker?