Open cdrini opened 4 years ago
Blocks: #3433. Until the UI for works and editions are separated out, it'll be too difficult and confusing for members to add work IDs when editing.
Loads of identifier (Wikidata IDs, GoodReads work IDs, LibraryThing IDs) apply only to works, and not editions.
Goodreads IDs are edition specific. These should remain at the edition-level.
👍 The majority should remain on the edition. But note that there are GoodReads work-specific IDs, they're just hard to find (e.g. https://www.goodreads.com/work/editions/2776383-the-driver-s-seat <- this url contains the work id). We might have to have some warning to avoid this being used incorrectly though, since I imagine it would be confusing.
Good point. I hadn't considered that as you have to get there via an edition. But it's subject to change. Because of the way the GR combination and separation works, it's possible if this gets combined incorrectly with a work that has an edition that has more "shelvings" than other editions, the work will then become that other work and the work with fewer editions will then have to be separated out into a new work.
There's no edit history on works, so I cannot give an example.
Pretty sure this is a duplicate of #1797 Edit: Not a duplicate but rather a superset. When we do this the other is closed. And the other can't be done until we do this.
@RayBB Not quite, that #1797 is just Wikidata IDs, but there are multiple work ID types just as there are multiple edition IDs. There are also multiple work classification IDs (see #897) for which we will still need to provide a distinct UI.
Documenting some questions I'm not totally sure about, and what I've decided in the code for now:
goodreads
and librarything
are listed under identifiers
but isbn_10
and lccn
are at the top level.https://openlibrary.org/books/OL18352429M.json
I'm assuming that all Work identifiers will go under identifiers
and so removed the code that checks for such special cases.
That OCAID are Edition level identifiers, and similarly to above, special code to handle them can be deleted.
That we don't have enough Work IDs to require the seperate list of popular and then alphabetized other IDs used for Editions.
That OCAID are Edition level identifiers, and similarly to above, special code to handle them can be deleted.
Internet Archive IDs don't actually correspond 1:1 with editions, but rather identify a particular scan/volume. Multi-volume editions and editions which have been scanned multiple times will both have multiple IA identifiers.
@davidscotson: "we don't have enough Work IDs to require the separate list of popular and then alphabetized other IDs used for Editions.". Really? Take a look at all the identifiers on ''Harry Potter and the Philosopher's Stone'' on Wikidata.
Currently we have no way to store identifiers on a work. Loads of identifier (Wikidata IDs, GoodReads work IDs, LibraryThing IDs) apply only to works, and not editions.
Summary of Requirements
"identifiers": {"goodreads": ["6675490"], "wikidata": ["Q91804864"], "librarything": ["9387249"]}
)Additional context
Stakeholders
@seabelis