internetarchive / openlibrary

One webpage for every book ever published!
https://openlibrary.org
GNU Affero General Public License v3.0
5.12k stars 1.34k forks source link

Test Open Library's Color Contrast #4522

Open bpmcneilly opened 3 years ago

bpmcneilly commented 3 years ago

For this task, we want you to take a look through all of the Open Library content & make sure the text has sufficient color contrast.

Steps

  1. Go through each of the pages under the 'Pages to Test' heading
    1. If you can't take on every page, no worries! Just add a comment here & let us know what pages you're reviewing ☺️
  2. Using a color contrast tool of your choosing (see the "Resources" heading below) measure the contrast of any new color combination
    1. Generally, the color contrast ratio of text should be 4.5:1 or higher
      1. If you select two colors in your checker, a ratio should be displayed - choosing white (#ffffff) and black (#000000), for instance, will create a contrast ratio of 21.0:1
      2. Some "Large Text" (that's at least 14 Point & Bolt or 18 Point) can be a lower ratio of 3.0:1
  3. If any color contrast ratios are too low, please file a bug (or better yet a PR!) related to this image
    1. General bug / PR formatting is available on the main Accessibility Issue: #4202
    2. For contrast issues / PRs, make sure you include what the current contrast ratio is & what you think alternative colors could be (and what those contrast ratios would be)

Resources

Pages to test

SaravgiYash commented 3 years ago

0 Contrast Errors

Sabreen-Parveen commented 3 years ago

@bpmcneilly and @Yashs911 I have checked login and Help pages, there are no color contrasts in them. https://wave.webaim.org/report#/https://openlibrary.org/help/faq/about https://wave.webaim.org/report#/https://openlibrary.org/account/login

SaravgiYash commented 3 years ago

0 Contrast Errors

Fix/Fixed Contrast Issues

  • Home Page #4538
  • Individual Subject Page #4558
  • Individual List Page #4558
  • Advanced Search #4571 (Red Search)
  • Search Results #4580
  • Search Inside Results #4580
  • Loans #4558
  • Privacy Settings #4571 (Red Cancel)
  • Edit Profile #4571 (Red Cancel)
  • Report a Problem #4571 (Red Cancel)
  • Add a Book #4571 (Red Cancel)
  • Book Page #4601

@bpmcneilly I think we have checked all the mentioned pages 🎉

bpmcneilly commented 3 years ago

@Yashs911 - Thanks to you and @Sabreen-Parveen for all your work on this! I'm reviewing now. I'm going to add a few new accessibility issues soon & may also format things differently to make tracking a little easier. Be on the lookout 😄

github-actions[bot] commented 8 months ago

Assignees removed automatically after 14 days.