search

internetarchive / openlibrary

One webpage for every book ever published!
https://openlibrary.org
GNU Affero General Public License v3.0
5.03k stars 1.29k forks source link

Carousels pulled from Lists only show works #6470

Open tmanarl opened 2 years ago

tmanarl commented 2 years ago

Currently, carousels that are created using patron lists only display works and not editions. Therefore, if a list contains multiple editions that belong to the same work, only a single instance of the work is displayed on the carousel.

Evidence / Screenshot (if possible)

Here is a list with 15 entries:

This carousel pulling from the same list only populates 3 entries:

Relevant url?

A Bible Collection Bible List

Steps to Reproduce

  1. Go to Bible List and verify the list has 15 entries.
  2. Go to A Bible Collection and observe the carousel labeled "Bible" is not populating all entries in the list.
  3. Verify the carousel code is pulling from list OL203794L.

Details

Proposal & Constraints

Related files

Stakeholders

bsvka commented 1 year ago

Curiously, when I try the same with a personal list of mine, I get different results. Editions get replaced by their work (i.e., they are shown), but it also adds items at the end - seemingly at random.

See this demo: https://openlibrary.org/collections/Schweizer_Buchpreis_Gewinner The QueryCarousel one is how I'd expect the ListCarousel one to look like.

Using the QueryCarousel is sub-par, since it requires extra steps to keep updated. First I would have to update the list itself, then the collections page; each year a new edit to both.