internetarchive / openlibrary

One webpage for every book ever published!
https://openlibrary.org
GNU Affero General Public License v3.0
5.13k stars 1.34k forks source link

Replace "Not In Library" button with "Check local libraries" #6525

Closed mekarpeles closed 1 month ago

mekarpeles commented 2 years ago

Related to #5831

Problem

Patrons get confused when they see a button that says "Not in library". It's a dead end. Instead, we should give them a default action of searching for an Open Library book within their local libraries using Worldcat or LibraryLink.

Describe the problem that you'd like solved

Replace Not in library button: openlibrary org_search_q=the+best+thing mode=everything

With Check local libraries: openlibrary org_search_q=the+best+thing mode=everything (3)

Proposal & Constraints

Additional context

Code: https://github.com/internetarchive/openlibrary/blob/master/openlibrary/macros/LoanStatus.html#L137-L140

Stakeholders

@jimchamp @cdrini @seabelis @JeffKaplan @bfalling

mekarpeles commented 2 years ago

For now, clicking btn will go to Worldcat, eventually we may wish to explore integrations which show library availability from within the context of Open Library and the other valuable info we're able to show on the book page.

tuminzee commented 2 years ago

@mekarpeles I see that you have self-assigned this issue. Would like me to work on this one?

mekarpeles commented 2 years ago

This one is a bit tricky and I'm almost done :)

mekarpeles commented 2 years ago

Prototype: Create a modal similar to the share modal which has tabs & iframe for checking Library.Link & Worldcat availability.

ThisIsRahmat commented 1 year ago

Hi @mekarpeles I want to contribute to this issue but you mentioned that you're working on it but there is no update since October. Is it okay for me to take on the issue?

I am a open source beginner so I don't know what the norm is.

tuminzee commented 1 year ago

hello @ThisIsRahmat I will list down few resources which can help you understand the codebase and flow better Readme.md https://github.com/internetarchive/openlibrary/blob/master/CONTRIBUTING.md

I hope this helps.

ayushdhiman-py commented 1 year ago

hey i want to work on this issue please assign me this issue

JaydenTeoh commented 1 year ago

Hi, I'll be taking on this issue. I'll make a PR within this week.

JaydenTeoh commented 1 year ago

@mekarpeles Here is my current implementation for the modal. Please ignore the styling for now as I would probably need the designer's input. But the functionality is there already, will make an initial PR first and continue working on it once the design is settled.

image
weshatheleopard commented 1 year ago

This button is confusing both the old and the new ways. Should be clearer. Like, "This book is currently checked out by another reader. Would you like to be notified once it is returned? Also, you can [ CHECK LOCAL LIBRARIES ]" (wording can be different, but this is the idea).

prasoon2510 commented 1 year ago

Yeah I am very happy to work with thus good first issue. Will you assign to me please

cdrini commented 1 year ago

Howdy folks, there's an open PR for this one, and this needs a bit more planning for direction :) Removing the good first issue label for now.

If you're looking for other places to help out, check out this list: internetarchive/openlibrary/issues (is:open label:"Needs: Help" label:"Good First Issue")

mekarpeles commented 4 months ago

The current state of this issue is that, instead of "Not In Library" the button should say: Locate using the primary color button and pop up a modal with worldcat results

tuminzee commented 4 months ago

@mekarpeles can I work on this issue?

mekarpeles commented 3 months ago

@tuminzee this one may be complicated as some books don't have ISBNs and there's still discussion about what type of experience should occur when the button is clicked and so I've assigned it to myself, sorry! ❤️

tuminzee commented 3 months ago

@mekarpeles that's cool I'll find some other issue 🕺🕺🕺

mekarpeles commented 1 month ago

@SivanC let's achieve this in our PR for #5831