internetarchive / openlibrary

One webpage for every book ever published!
https://openlibrary.org
GNU Affero General Public License v3.0
4.99k stars 1.25k forks source link

Implement new design for the "my lists" section of the my books page #7704

Closed danafein closed 1 month ago

danafein commented 1 year ago

We would like to add a new "my lists" section at the bottom of the my books page. The design for this section is pictured here:

Screen Shot 2023-03-22 at 2 11 41 PM

https://www.figma.com/design/dYQkIJOJeMo9hx7ewZQH9x/Open-Library%3A-Design-System-%26-Component-Library?node-id=1808-188&t=GkpeOtQM5KXBVn4Q-4

The main components of this design are:

Here is an additional image, which shows the location of list section in relation to the rest of the my books carousels:

Screen Shot 2023-03-22 at 2 11 57 PM

For any clarifying questions about the design, please reach out to @danafein

Stakeholders

MaAnCoSa commented 1 year ago

Hi! I am new to contributing to open-source projects. Can I give this issue a try?

danafein commented 1 year ago

@MaAnCoSa yes, I just assigned the issue to you! Thank you for your interest in working on it!

MaAnCoSa commented 1 year ago

I am trying to work with the style of the different containers for a new carousel, but I have never worked with Less for the CSS files. I am trying to test if I can see changes creating a new class style in the carousel.less file (it just sets the div background to light blue), but the changes are never shown when refreshing the browser. I also tried restarting the docker container to see if that would recompile the CSS files with the changes in the Less files, but it's still the same.

What is the correct way of altering the styles in this project?

scottbarnes commented 1 year ago

@MaAnCoSa, the information is a bit spread out, but have you checked out Building CSS and JS?

MaAnCoSa commented 1 year ago

@scottbarnes I had not checked that! I used the watch script and everything shows now. Thank you.

gaurav-2-0-0-2 commented 1 year ago

is this issue resolved ?

danafein commented 1 year ago

I believe @MaAnCoSa is still working on it! @MaAnCoSa, how is this issue coming? Do you have any questions?

gobbledy-gook commented 1 year ago

Is this issue still active or is it resolved ?

scottbarnes commented 1 year ago

Hi, @gobbledy-gook. There is a linked pull request (#7743), but there is a bit of a backlog in the PR reviews. Sorry! :(

20481A05K0 commented 11 months ago

good morning everyone Is this issue still exists or can you assign that to me i will try to handle

jimchamp commented 10 months ago

There is already a PR open for this issue. If you're looking for a good first issue, check out this list: https://github.com/internetarchive/openlibrary/issues?q=is%3Aopen+is%3Aissue+label%3A%22Needs%3A+Help%22+label%3A%22Good+First+Issue%22