search

internetarchive / openlibrary

One webpage for every book ever published!
https://openlibrary.org
GNU Affero General Public License v3.0
5.21k stars 1.37k forks source link

Remove inline js: swagger/swaggerui.html #8381

Open RayBB opened 1 year ago

RayBB commented 1 year ago

Remove the inline JS from this file following the recommended steps in #4474

Proposal & Constraints

This should be very easy to change and test.

Related files

https://github.com/internetarchive/openlibrary/blob/master/openlibrary/templates/swagger/swaggerui.html

This PR is almost there, just needs some small tweaks https://github.com/internetarchive/openlibrary/pull/8472

Stakeholders

rohitkbc commented 1 year ago

Hey 👋 @RayBB, Can I work on this issue? 😊

RayBB commented 1 year ago

@rohitkbc yes go ahead

RayBB commented 1 year ago

@rohitkbc do you need any help with this?

rohitkbc commented 1 year ago

@RayBB, I am sick 😷 for last 4-5 days. I didn't get time to look into the issue. As soon as I feel better, I will work on this issue and if stuck, I will ask for help. 😊

RayBB commented 1 year ago

Hope you're feeling better. Let me know if you're still interested in working on this.

On Sat, Oct 14, 2023 at 8:21 AM Rohit Chaudhari @.***> wrote:

@RayBB https://github.com/RayBB, I am sick 😷 for last 4-5 days. I didn't get time to look into the issue. As soon as I feel better, I will work on this issue and if stuck, I will ask for help. 😊

— Reply to this email directly, view it on GitHub https://github.com/internetarchive/openlibrary/issues/8381#issuecomment-1762660576, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHA5AOV4PHU3F5CUQEJE7DX7IVNBANCNFSM6AAAAAA5U6KL6E . You are receiving this because you were mentioned.Message ID: @.***>

rohitkbc commented 1 year ago

Yes @RayBB , I am still interested to work on this.

rohitkbc commented 1 year ago

Hi @RayBB 👋, actually I am occupied with some other works. Thanks for giving me chance for contribution 🤝 . Even though currently I am not able to contribute, certainly I will in near future 🤞

RayBB commented 1 year ago

@rohitkbc no problem. You're always welcome back :)

mudit-loya commented 1 year ago

Hello @RayBB sir, I would like to take up this issue.

RayBB commented 1 year ago

@imperial-chief go for it :)

mudit-loya commented 1 year ago

@RayBB can you tell me where to write the removed javascript code?

RayBB commented 1 year ago

@imperial-chief I think you can do something similar as to what you did in #8447

ayushman075 commented 10 months ago

i want to resolve this issue