internetarchive / openlibrary

One webpage for every book ever published!
https://openlibrary.org
GNU Affero General Public License v3.0
5.11k stars 1.33k forks source link

Use Richer UI install for PWA on Chrome #8929

Open RayBB opened 6 months ago

RayBB commented 6 months ago

Chrome supports a richer install UI for progressive web apps.

We can include screenshots (both mobile and desktop) and a description.

Img of how it looks

Describe the problem that you'd like solved

Use these new features to improve the experience.

Proposal & Constraints

Your task:

Note: this is not compatible with Firefox

If you would like to work on this please just say you'd like to work on it and get started. I'll assign it to you when I get a chance.

Additional context

Stakeholders

Sameer-Pal commented 6 months ago

Hi, @RayBB I'd like to work on that

RayBB commented 6 months ago

@Sameer-Pal that would be wonderful!

RayBB commented 5 months ago

@Sameer-Pal please let me know if you're still working on this. Otherwise we can give someone else a chance to work on it.

Sameer-Pal commented 5 months ago

Hi, @RayBB I'am working on it, I'll deliver the PR shortly!

Sameer-Pal commented 5 months ago

Hi, @RayBB It's been written to clone using SSH not using HTTPS but it's not working that way! Bcz, key is not provided Should i run it using HTTPS ? Screenshot (716)

scottbarnes commented 5 months ago

@Sameer-Pal, it may be the case that you need to add your SSH key to GitHub. If you've not tried the steps in Permission denied while cloning, they may be worth checking out.

OfcPeriwinkle commented 5 months ago

@Sameer-Pal, did you mean to remove your assignment from this issue or are you still working on a PR?

I might be interested in taking this over if you are looking to hand it off.

RayBB commented 5 months ago

@OfcPeriwinkle please go ahead and try. You're assigned now.

OfcPeriwinkle commented 5 months ago

Just wanted to post an update since it's been a little bit. I submitted a volunteer form a few days ago and I'm just waiting on the Slack invite. I have a draft description and some screenshots for review once I'm able to join the channel.

I tested out the manifest locally with the desktop screenshots I have and everything looks like what we'd expect. I'm not too sure how to go about testing the mobile install UI locally so if someone has an idea of how to do that I'm all ears!

RayBB commented 5 months ago

@mekarpeles can you check the volunteer form? @OfcPeriwinkle please share your draft here. For mobile you can try gitpod and access the address you get from your phone.

RayBB commented 4 months ago

@OfcPeriwinkle are you still working on this?

OfcPeriwinkle commented 4 months ago

@RayBB Just started a new job so I've been busy with onboarding. I'll post what I have for review once I get some time this week.

OfcPeriwinkle commented 4 months ago

Apologies for the delay, here are the draft screenshots and description.

Description

Landing Page

Search

Student Library

Trending

Lists

RayBB commented 4 months ago

@OfcPeriwinkle I think these look pretty fantastic. I'm going to see if we can get any community feedback. However, I think you can open a PR now as the basics of these are probably going to stay the same.

Thanks!

RayBB commented 4 months ago

@mekarpeles @cdrini do either of you wanna provide feedback this?

cdrini commented 1 week ago

Taking a look at this now; those look great @OfcPeriwinkle ! We have a similar set of screenshots we use for the play store here: https://github.com/internetarchive/openlibrary/blob/59c8fa5ce588020633ee0f16d23aa052d8a43ea9/conf/twa/Play_Store_SS.mockup . It has screenshots for a few of the places you have taken screenshots, but they're a bit outdated. Would you be able to update the .mockup file with screenshots for the current site? And use the same format to create new screenshots for desktop.

For the description, let's copy it from the play store to be consistent: Open Library is an open, editable library catalog, building towards a web page for every book ever published. Read, borrow, and discover more than 3M books for free.