search

internetarchive / openlibrary

One webpage for every book ever published!
https://openlibrary.org
GNU Affero General Public License v3.0
4.97k stars 1.25k forks source link

Add share links to author pages #9141

Open jimchamp opened 2 months ago

jimchamp commented 2 months ago

Describe the problem that you'd like solved

It's more cumbersome to share author pages than it could be. Today, the URL most be copied manually, then shared with others.

Proposal & Constraints

Other pages, like the books page, contain a share modal that gives a number of options for sharing links. Let's add this to author pages, as well.

Additional context

This is related to #452, which is primarily concerned with adding a QR code option to the share modal. This issue was created to reduce the scope of the aforementioned issue.

Stakeholders

@LeadSongDog

aggelasdinou commented 2 months ago

Hello, i am currently new to contributions and i am interested in working on this issue. Could you please provide more info on where the share modal should be?

jimchamp commented 2 months ago

The link for the share modal can go on the top-right corner of the view, to the right of the "Edit" button. You can use the same image and styling as the book page share link: image

Searching for ShareModal in .html files will give insight into how our share modals are added to other pages.

ManavSarkar commented 1 month ago

may i take this issue?

aggelasdinou commented 1 month ago

The link for the share modal can go on the top-right corner of the view, to the right of the "Edit" button. You can use the same image and styling as the book page share link: image

Searching for ShareModal in .html files will give insight into how our share modals are added to other pages.

Hello, i really appreciate the response and i will be working on the issue the following days. I ll let u know soon!

jimchamp commented 1 month ago

may i take this issue?

No @ManavSarkar, it has already been assigned to somebody else.

aggelasdinou commented 1 month ago

@mekarpeles @jimchamp Hello! I wanted to give an update on this issue. I think it is almost done, we are just waiting on a feedback.You can check our modification on my branch (https://github.com/aggelasdinou/openlibrary/tree/9141/feature/add_shareModal_authors). Also, as i am working together with @Tzinapapadopoulou , is it possible to add her as an assignee?

jimchamp commented 1 month ago

Hi @aggelasdinou. If the branch is ready for feedback, please open a pull request.

Unless a contributor has elevated access to a repository, they can't be added as an assignee to an issue until they have commented on the issue thread.

Tzinapapadopoulou commented 3 weeks ago

Hello, we are still working on it. Actually, we have adjust our changes to the mobile version. Can you add me as an assignee? @jimchamp

scottbarnes commented 2 weeks ago

@Tzinapapadopoulou and @aggelasdinou, @jimchamp is away currently but will review the associated PR when he gets back. In the interim, I've added you as an assignee, @Tzinapapadopoulou.