Consolidate cover previews on search results

internetarchive / openlibrary

One webpage for every book ever published!

https://openlibrary.org

GNU Affero General Public License v3.0

4.99k stars 1.25k forks source link

Consolidate cover previews on search results #9468

Open mekarpeles opened 3 weeks ago

mekarpeles commented 3 weeks ago

Problem

Cover previews take up a lot of real estate. We want to make room for #2405 / #9463

Expected behaviour / screenshots (ex: Figma design screenshots for UI feature)

From:

To:

From:

To:

Proposal & Constraints

No response

Leads

Related files

Stakeholders

Instructions for Contributors

Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

Spedi commented 3 weeks ago

Hi there! Can I try to work on this? I am not sure on how to achieve the wanted result, could you point me to some resources I could look at to get an idea of the code involved? Thank you!

bazylevnik0 commented 3 weeks ago

Hi there! Can I try to work on this? I am not sure on how to achieve the wanted result, could you point me to some resources I could look at to get an idea of the code involved? Thank you!

~~I think(can be wrong) it here: https://github.com/internetarchive/openlibrary/blob/master/openlibrary/templates/books/works-show.html#L17~~ Here: https://github.com/internetarchive/openlibrary/blob/master/openlibrary/macros/SearchResultsWork.html#L63 As I understand we can create another loop with templetor, and fix position of book covers by CSS.

bazylevnik0 commented 3 weeks ago

@Spedi In my PR I am trying to solve only part of this issue, only cover images.