BookBrainz, MusicBrainz identifiers easily mislabeled as StoryGraph identifiers

stopregionblocking commented 1 week ago

Problem

Because all 3 libraries use UUIDs & Storygraph identifiers were integrated into OL first, when adding author identifiers the menu which guesses what kind of identifier you're including will automatically guess StoryGraph. This makes mistakes far easier.

Evidence / Screenshot

Relevant URL(s)

https://github.com/internetarchive/openlibrary/issues/8480#issuecomment-1806759638

Reproducing the bug

Go to edit an author page.
Copy a BookBrainz or MusicBrainz author identifier.
Paste it into the identifier field.

Expected behavior: The field either guesses it to be BookBrainz/MusicBrainz identifier (admittedly difficult) or does not attempt to guess the source.
Actual behavior: The field guesses it to be a StoryGraph identifier.

Context

Browser (Chrome, Safari, Firefox, etc):
OS (Windows, Mac, etc):
Logged in (Y/N): Y
Environment (prod, dev, local): prod

Notes from this Issue's Lead

Proposal & constraints

Related files

Stakeholders

Instructions for Contributors

Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

mekarpeles commented 4 days ago

I think the solution may be to not try to guess if it's a UUID.

Freso commented 6 hours ago

Isn’t @RayBB working on something with Wikidata data to "guess" identifiers using the whole URL? If that’s meant to replace the current simple system, that might also solve this issue. (Though, of course, I don’t know how far along that is, so it might be prudent to simply remove the UUID guessing until then… I can probably poke at the code and yoink that out.)

internetarchive / openlibrary