internetarchive / openlibrary

One webpage for every book ever published!
https://openlibrary.org
GNU Affero General Public License v3.0
5.06k stars 1.31k forks source link

Use new search box on reading log pages, author page #9557

Closed cdrini closed 3 weeks ago

cdrini commented 1 month ago

Problem

The reading log pages, e.g. https://openlibrary.org/people/ScarTissue/books/want-to-read , and the author page, e.g. https://openlibrary.org/authors/OL33146A/Franz_Kafka , feature search boxes which should use the new updated style introduced in #9146

image

image

Proposal & Constraints

What is the proposed solution / implementation?

Is there a precedent of this approach succeeding elsewhere?

Which suggestions or requirements should be considered for how feature needs to appear or be implemented?

Leads

Related files

Reading log pages:

https://github.com/internetarchive/openlibrary/blob/d9e5424beb2cf524aaf30452e5a6254afce384b3/openlibrary/templates/account/reading_log.html#L46-L49

Author pages:

https://github.com/internetarchive/openlibrary/blob/452943391f40d2d798d8a74b455f0493e0fc6333/openlibrary/templates/type/author/view.html#L138

Stakeholders

@0simoo


Instructions for Contributors

Souvik-Cyclic commented 1 month ago

@cdrini I want to work on this, assign this to me.

cdrini commented 1 month ago

Apologies for the confusion folks, I didn't see the comments in time. I'm leaving this one with @dwrik since they opened a PR and are actively working on it, although for future reference @dwrik, if there are comments from other contributors on an issue please do wait for a maintainer to respond before beginning :+1:

dwrik commented 1 month ago

@cdrini

Apologies from my end as well. The issue wasn't assigned and there was no confirmation on whether someone had started working on it so I assumed it wasn't being worked on by anyone. Nonetheless, from next time onwards, will wait for a maintainer to respond before working on it. Thanks.

educonnec commented 1 month ago

thanks for sharing this coding toutatice.