Delete `around_the_library.html` and `get_random_recent_changes` if unused

internetarchive / openlibrary

One webpage for every book ever published!

https://openlibrary.org

GNU Affero General Public License v3.0

5.13k stars 1.35k forks source link

Delete `around_the_library.html` and `get_random_recent_changes` if unused #9896

Closed scottbarnes closed 3 days ago

scottbarnes commented 2 weeks ago

Problem

We should delete openlibrary/templates/site/around_the_library.html and get_random_recent_changes from openlibrary/plugins/upstream/utils.py if unused.

Breakdown

Requirements Checklist

[ ] Verify the two things above are not called by anything besides perhaps one another by looking at the code (perhaps with the help of git grep).
[ ] IF they are unused, delete the file and function.

Related files

Stakeholders

Instructions for Contributors

Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

JorgeSanchez-ENC commented 2 weeks ago

Hello!, can this issue be assigned to me?

scottbarnes commented 2 weeks ago

@JorgeSanchez-Encora, I've assigned this to you. Because of the nature of this task, it's a bit hard to demonstrate it had no adverse effects across the entire site, but if you determine these things can be deleted, please explain the steps you took and your rationale in making that determination. Thanks!

siddarth2810 commented 1 week ago

Hiiii, I did a grep search and found get_random_recent_changes was only used in the around_the_library.html. I think its safe to remove the function. grep

just to be safe, i also searched around_the_library in the whole repo and found its only referenced in the messages.po.

atl

so i think we can delete the file and the function like you suggested. Would love to hear your thoughts on this @scottbarnes

scottbarnes commented 1 week ago

Thank you, @siddarth2810. That looks right to me. @JorgeSanchez-Encora, are you still interested in working on this?

siddarth2810 commented 1 week ago

If its alright, would love to take this up 😄

JorgeSanchez-ENC commented 6 days ago

Im sorry I got a little busy at work, it seems that siddarth has figure it out

scottbarnes commented 6 days ago

No worries at all, @JorgeSanchez-Encora. @siddarth2810, I've assigned this to you. Please let me know if you have any questions.