Broken cover image - Githubissues

internetarchive / openlibrary

One webpage for every book ever published!

https://openlibrary.org

GNU Affero General Public License v3.0

5.15k stars 1.35k forks source link

Broken cover image #9921

Open zorae opened 1 week ago

zorae commented 1 week ago

Problem

Some editions have a cover image that cannot be loaded/rendered.

Reproducing the bug

Navigate to the following edition: OL13502500M

Expected behavior: Either there is no cover image, or there is a visible cover image
Actual behavior: The browser displays a broken image placeholder

Context

Browser: Safari
OS: iPadOS 18
Logged in: Y
Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

Related files

Stakeholders

Instructions for Contributors

Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

scottbarnes commented 1 week ago

@zorae, I currently see a cover for this specific edition. I am curious if you continue to not see one.

zorae commented 1 week ago

In Safari on both iPhone and iPad, the image is still broken for me. Maybe you’re serving an unusual image format?

zorae commented 1 week ago

@scottbarnes The -M version of the image seems to work correctly. But when navigating to the -L image URL, I get the following error message:

cmd: LANG=en_US.UTF-8 timeout 180 unzip -p '/16/items/olcovers674/olcovers674-L.zip' '6747253-L.jpg' 2>/dev/null
failed with exit status: 11

Bishal-35 commented 2 days ago

Hii!! Can i work on it?

scottbarnes commented 2 days ago

@Bishal-35, thanks for your interest in this. I would say hold that thought until after this issue is triaged on Monday, unless you have a really clear vision for how to fix it, as I think this may require additional privileges / staff.

For my part, I'm curious to know what the output is when STDERR isn't discarded, and I think that will may depend on what's inside /16/items/olcovers674/olcovers674-L.zip, and whether that file exists at all.

Bishal-35 commented 2 days ago

Okay. I will for it