Changes to make library compatible with Python3.

baali commented 8 years ago

Hello,

I have been working on to make the library work with Py3. Changes include:

Fixing StringIO import and its usage.
Fixing obsolete builitin import.
Fixed obsolete DictMixin import for base class and corresponding changes in arguments.
Specific cases of handling str and bytes type to make sure things are working.
There are changes in GZipFile, fixed read_member function of GzipFile to return _buffer element for py3.

Existing tests are working fine with this PR but I think they need to be extended to make sure handling of bytes and str types are working in all possible scenarios. Do let me know your comments and reviews and I will fix and update the PR accordingly.

pwaller commented 7 years ago

Ping @nibrahim - this would be useful to quite a few people - I've sent you a personal email, too.

piercefreeman commented 6 years ago

Would also love to see this merged. /cc @mekarpeles since he's an active maintainer of other internet archive projects.

baali commented 6 years ago

I haven't worked again with this from quite some time, do let me know if you have noticed any bugs and I would be happy to update my PR with fixes... :pray:

piercefreeman commented 6 years ago

@baali Noticed one around byte length calculations... Want me to put up a PR on your branch?

baali commented 6 years ago

@piercefreeman That would be great :+1:

piercefreeman commented 6 years ago

@baali Put up a PR - let me know when you get a chance.

jbrockmendel commented 5 years ago

ping. Is this or something like it going to be accepted?

internetarchive / warc

Changes to make library compatible with Python3. #26