Closed vbanos closed 6 years ago
We use record.write_to inside the WarcWriter.write_records method and we flush() the file after writing to make sure that data are written to disk.
record.write_to
WarcWriter.write_records
flush()
The record.write_to method already finishes with a flush()! https://github.com/internetarchive/warctools/blob/master/hanzo/warctools/warc.py#L127 Thus, it is redundant.
We use
record.write_toinside theWarcWriter.write_recordsmethod and weflush()the file after writing to make sure that data are written to disk.The
record.write_tomethod already finishes with aflush()! https://github.com/internetarchive/warctools/blob/master/hanzo/warctools/warc.py#L127 Thus, it is redundant.