Remove redundant RLock from WarcWriterPool

internetarchive / warcprox

WARC writing MITM HTTP/S proxy

379 stars 54 forks source link

Closed vbanos closed 6 years ago

vbanos commented 6 years ago

WarcWriterPool._lock seems redundant. WarcWriter already has locking.

I removed it and run various tests without an issue.

There is also a performance increase (around ~0.5-1 sec) when running benchmarks/run_benchmark.py

vbanos commented 6 years ago

This lock is necessary and it shouldn't be removed.