[Enhancement] We should add a time restriction for "Save Page Now" option, to limit load atack possibilities - Githubissues

internetarchive / wayback-machine-firefox

Reduce annoying 404 pages by automatically checking for an archived copy in the Wayback Machine. Learn more about this Test Pilot experiment at https://testpilot.firefox.com/

GNU Affero General Public License v3.0

53 stars 17 forks source link

[Enhancement] We should add a time restriction for "Save Page Now" option, to limit load atack possibilities #77

Open SoftVision-PaulOiegas opened 7 years ago

SoftVision-PaulOiegas commented 7 years ago

[Notes]:

With current implementation, using a simple and free record an play tool we can flood the server with save page requests. Maybe we should consider to add some kind of time restriction, until you can save the same page again.

[Affected versions]:

Nightly 54.0a1
NoMore404s 1.7.1

[Affected Platforms]:

All Windows
All Mac
All Linux

[Prerequisites]:

Latest NoMore404s add-on (v1.7.1) was previously installed on a new profile.

[Steps to reproduce]:

Open the browser with the profile from prerequisite.
Navigate to any website page.
Click the "NoMore404s" button and choose the "Save Page Now" option.
Return to the original page and choose to save it again.

[Expected result]:

You are unable to save the same page again if the page was already saved recently.

[Actual result]:

You can save the same exact page as many times as you want.