search

internetarchive / wayback-machine-webextension

A web browser extension for Chrome, Firefox, Edge, and Safari 14.
GNU Affero General Public License v3.0
667 stars 207 forks source link

Update dependancies and package.json file #991

Closed anishsarangi closed 1 year ago

anishsarangi commented 1 year ago
  1. Updated the package that needs updating
  2. Move bootstrap and fontawesome-free from devDependencies to dependencies since they are used at runtime.
  3. Move url-loader from dependencies to devDependencies.
  4. Fix an warning issue for bootstrap.css.map System error: net::ERR_FILE_NOT_FOUND
cgorringe commented 1 year ago

We're not using webpack anymore to create a build.js script for production. The javascript libraries used are manually placed in webextension/libs and the html points to those files (which are not updated when runningnpm run-script build) and the reason for this is to make sure the libraries are readable and non-minified to pass code review. Now this can be fixed to work with webpack with some extra effort (and being careful about possible breaking changes in newer versions of the libraries, such as Bootstrap) but the easy route is to probably just move everything to devDependencies and empty dependencies. (I have not tested this)

anishsarangi commented 1 year ago

We still need jquery as a dependancy for the testing. So I am moving out all the other dependancies and moving them to devDependencies.