internetee / registry

TLD Management Software
Other
46 stars 19 forks source link

ForceDelete - conflicting statuses and too much log #2561

Closed vohmar closed 1 year ago

vohmar commented 1 year ago

On 9th of April forceDelete was unexpectedly removed from a domain with invlaid email address without the change to the address

The preceeding record for the email validation had this info:

"errors": {"mx": "target host(s) not found"}, "success": true,

notice the conflict - error exists but success is true. The last one is the reason why the FD was lifted. This should not be. further investigation showd that from the DNS or MX check perspective the email address is actually valid as the domain has IPv4 and IPv6 addresses set. But in reality there is no service behind it. Why is there an error and passed validation simultaneously

There are 1508 records in prod with error message and success = true. Out of those 5 have error "email does not match the regular expression" the rest all share the "target host not found" message

The second part of the problem is the logging. The fd lift job is running every hour and creates a record in domain history for all the FD domains

sample of object_changes records: 2023-04-09 03:56:11.384588+03 | {"updated_at": ["2023-04-09T02:56:12.783+03:00", "2023-04-09T03:56:11.384+03:00"]}

in the logs there are much more detailed record for CheckForceDeleteLift every check and again nothing really changes there except the date. The records are created for every FD domain every hour that is more than 3000 records every day. Need to reduce the data logged and stop creating records in the domain changes when nothing is really changed there.