search

internetee / registry

TLD Management Software
Other
45 stars 19 forks source link

Normalize nameserver IPv6 to lowercase #736

Open artur-intech opened 6 years ago

artur-intech commented 6 years ago

Name server's IPv6 is automatically normalised to uppercase chars whereas

The hexadecimal digits are case-insensitive, but IETF recommendations suggest the use of lower case letters

https://en.wikipedia.org/wiki/IPv6_address#Representation

Derived from #661

artur-intech commented 6 years ago

Artur:

@ratM1n @teadur What do you think about this change? If I change it now to lowercase, existing database records remain upper-cased, which can lead to problems with comparison at both application and database level (both are case-sensitive).

So there are 2 options:

Enforce lowercase, convert existing records ones Leave upper-cased records as is, and say convert to lowercase only when displaying it (in representation)

teadur commented 6 years ago

@artur-beljajev I think enforcing lower case makes more sense. User input should be normalized to lowercase on input.

artur-intech commented 6 years ago

Is it OK to normalize existing records as well?

teadur commented 6 years ago

I don't see any problem with it.