search

internetitem / logback-elasticsearch-appender

Logback Elasticsearch Appender
Other
233 stars 137 forks source link

New setting maxEvents to limit number of log events added for later processing #45

Open huksley opened 6 years ago

huksley commented 6 years ago

Limits memory affected by issue #44

arunmohapatra commented 6 years ago

Need to add support of tomcat juli log back

huksley commented 6 years ago

@arunmohapatra can you elaborate? is there anything I should do?

PeterFokkinga commented 6 years ago

@huksley I believe Arunmohapatra refers to his issue #54 that has nothing to do (for I can see) with your PR.

But I think you still need to assign @abatkin as a reviewer if you want to have him include your code for the next release? (my hosting provider would be very happy if could set maxEvents!)

almson commented 4 years ago

I suspect (but haven't confirmed) a performance problem: deleting the first element of a big ArrayList is an expensive operation. Either change list type to LinkedList or drop new events instead of old ones.