search

internetitem / logback-elasticsearch-appender

Logback Elasticsearch Appender
Other
233 stars 137 forks source link

added https url support #52

Closed amirinenik closed 6 years ago

amirinenik commented 6 years ago

checked url protocol and opened connection for https url support.

abatkin commented 6 years ago

This will work, but I don't understand what it accomplishes? HttpUrlConnection is already the superclass of HttpsUrlConnection so it shouldn't need a cast to the subclass, unless you need to do something special with the subclass.

amirinenik commented 6 years ago

Correct. I am trying to fix the self signed cert issues. I will close my request and come up with cert issues fixes in case of self signed or invalid certs.