Improvements and maintenance

internetitem / logback-elasticsearch-appender

Logback Elasticsearch Appender

Other

233 stars 137 forks source link

Improvements and maintenance #75

Open MkCons opened 4 years ago

MkCons commented 4 years ago

Hi,

I have made a few improvements on the appender:

Clear the log buffer so that when the program is about to finish pending messages are sent to Elasticsearch.
Add the capability of transmitting compressed messages.
Add the capability of logging Java POJOs as JSON.
Whenever a key-value parameter is logged as part of a message “serialized document with docOid=1234”, we log it outside as well, as other appenders do “serialized document with docOid=1234” + “docOid=1234”.
Allow the users to add a keyPrefix, so we would have prefix.docOid=1234.

I have not seen much activity in the repo lately though. To the original maintainers, are you guys still there? And if so, do you have plans for a 1.7 release?

Best,

abatkin commented 4 years ago

Still here...just distracted with other things (sorry).

I haven't done a release in a while because I don't (currently) have an ES cluster to test anything against, so while there a bunch of PRs outstanding, I feel weird about merging and releasing without being able to test anything.

MkCons commented 4 years ago

Heya,

No apologies necessary.

I've been testing my changes on a single ES + Kibana on my laptop. Is there any reason we would need to do that in a cluster?

Lucas3oo commented 3 years ago

It would be really great to see those PR merged into main. Especially issues around memory leaks and setup/ configuration. There are many forks so your lib is really used a lot too :-) /Lucas

veenarm commented 2 years ago

Guessing the project is now not maintained?

abatkin commented 2 years ago

I would be open to doing a release (and potentially adding maintainers), but I would need some help (since I don't actively use this regularly anymore, and I don't have a convenient ElasticSearch cluster to test with).

If a few interested folks want to propose the list of PRs that should go into the next release, I can push a test branch with all of those in it. If a couple folks vouch that it all still works (and no one else has objections), I will merge and push that out as a release.

jonahbenton commented 2 years ago

Wanted to chime in, I'm on a team that just started using this appender with OpenSearch, eager to see some enhancements, and would be happy to test a release.

agido-malter commented 1 year ago

Wanted to chime in, I'm on a team that just started using this appender with OpenSearch, eager to see some enhancements, and would be happy to test a release.

It looks like this project has been abandoned. We and some others use this library and we decided some time ago to continue it. The libs used are up to date and a number of pull requests are merged. This isn't to steal a project, we're just keeping it up to date. See agido-malter/logback-elasticsearch-appender