internetofwater / geoconnex.us

URI registry for https://geoconnex.us based URIs
Other
24 stars 16 forks source link

Add a geospatial fabric namespace #102

Closed dblodgett-usgs closed 3 years ago

dblodgett-usgs commented 3 years ago

This is kind of a pilot -- will update it before too long, but the usgs/gfv11_pois namespace with a regex redirect will be pretty stable.

ksonda commented 3 years ago

I believe there are a few things wrong with this.

a) I believe the features you are pointing to use this identifier scheme in the field 'uri': https://geoconnex.us/usgs/GFV_1_1/{prvdr_d}

but your request is for https://geoconnex.us/usgs/gfv11_pois/{x}

for example you have https://geoconnex.us/usgs/gfv11_pois/6742250 pointing to a feature with "uri":"https://geoconnex.us/usgs/GFV_1_1/1"

b) In your layer, sbjctOf points to https://www.sciencebase.gov/catalog/item/5e29b87fe4b0a79317cf7df5, not the corresponding feature (WFS call). This is more of a check, not sure if this is desired

c) for your own sanity update the usgs readme with this

d) not wrong -- I need to update our docs on this. We found that an efficient way to encode regex is to prepend "/". So in this example, "id" would be https://geoconnex.us//usgs/gfv11_pois/([a-zA-Z0-9_]+).*$ . Makes the DB lookup fast without needing to loop through regex expressions the way CSIRO PIDsvc did. The server strips the extra "/" before redirecting

dblodgett-usgs commented 3 years ago

Thanks for the thorough review. a) I need to update the WFS to use the PID pattern here. b) I do want the subjectOf to point to that dataset c) please don't merge until I've fixed the README -- this is kind of a WIP. d) good tip. I'll get that fixed in the csv in my next commit.

dblodgett-usgs commented 3 years ago

OK -- I think I have this where it needs to be to merge.

ksonda commented 3 years ago

Ça marche!