Setting `INTERNET_NL_CHECK_SUPPORT_... = False` breaks results page

[uwekamper]

The following environment variables can be set to disable/enable some checks (the default is that they are all enabled):

• INTERNET_NL_CHECK_SUPPORT_IPV6
• INTERNET_NL_CHECK_SUPPORT_DNSSEC
• INTERNET_NL_CHECK_SUPPORT_MAIL
• INTERNET_NL_CHECK_SUPPORT_TLS
• INTERNET_NL_CHECK_SUPPORT_APPSECPRIV
• INTERNET_NL_CHECK_SUPPORT_RPKI

In the settings:

https://github.com/internetstandards/Internet.nl/blob/894aa0418e5cc24c3fac25cdc89c50cbed555395/internetnl/settings.py#L102

Now here is the problem: When one of the above environment variables is set, e.g. INTERNET_NL_CHECK_SUPPORT_RPKI=False, then the user is never redirected to the results page.

The reason is as follows: When the user is waiting for results, the URL / domain/<dname>/results/ is regularly checked to see if the running checks are finished. This view function just assumes that all the checks are enabled all the time and thus the users never get the redirect to the results page. The user will see the "waiting for results" page forever.

We already have a fix for this problem and would like to submit a pull request.

[mxsasha]

We'd be happy to have a PR - we rarely use these settings ourselves, so it is possible there are bugs we haven't run into ourselves.

[baknu]

@stitch Could you check this too, since IIRC you wrote the code for this? Thanks!

[uwekamper]

Happy New Year, I just added a PR (see #1219 ) that fixes the problem for domain and mail checks.

If you want to it try out, you can add the following line to your environment file (e.g. docker/develop.env):

INTERNET_NL_CHECK_SUPPORT_RPKI=False

and then run make up env=develop. The RPKI checks then will not be started anymore (though routinator will still be started by the docker-compose setup).

[uwekamper]

Any news on this? Did you have a chance to look at our PR?

[stitch]

Merged after fixing some linting, thanks you! https://github.com/internetstandards/Internet.nl/pull/1233

[uwekamper]

Yay! \o/