Allow 4xx and 5xx in IPv4/IPv6 similarity hash

internetstandards / Internet.nl

Internet standards compliance test suite

https://internet.nl

171 stars 35 forks source link

Allow 4xx and 5xx in IPv4/IPv6 similarity hash #1267

Closed mxsasha closed 4 months ago

mxsasha commented 6 months ago

As discussed, the IPv4/IPv6 similarity hash should return to its pre 1.8 behaviour and permit all response codes - if they are the same. For 4xx/5xx, we should return a warning ⚠️.

Related: #1226

mxsasha commented 6 months ago

From #1271, we still need to add a label detail web ipv6 web-ipv46 verdict notice-status-code

mxsasha commented 6 months ago

Somehow, a bunch of commits mention #1267 but are actually meant for #1258

mxsasha commented 5 months ago

@baknu as this is the last open blocker, I've gone ahead and made the labels: https://github.com/internetstandards/Internet.nl_content/commit/b0c47b761f167b2e37fef9377d933969fb21bb9b

baknu commented 4 months ago

Content seems fine to me. Added this issue to #1253. Closing the issue.