internetstandards / Internet.nl

Internet standards compliance test suite
https://internet.nl
166 stars 36 forks source link

Test reports on dev-docker.batch should be publicly accessible with a direct link #1321

Closed stitch closed 3 months ago

stitch commented 4 months ago

A report like the following is linked on the dashboard next to the metrics. This link is used to view the entire test report. This works fine on production but on the new batch environment a login screen is presented. The links to these reports should be publicly accessible in some way.

Example of report where login is shown on acc: http://dev-docker.batch.internet.nl/site/20072020.europaomdehoek.nl/19067/

Example where the result is public: https://batch.internet.nl/mail/2017.jaarverslaghogeraad.nl/7680087/

The link is used on (public) reports here, see the internet.nl icon on the left: image

Authenticated users of the dashboard are also presented the credential screen, which can be very annoying (although probably one time given it is htaccess).

mxsasha commented 4 months ago

Oh, this is an intentional feature for #1274 #1286, which I have currently deployed on dev-docker.batch. We decided there we should limit access to all URLs, so I guess that was wrong. We should refine this.

bwbroersma commented 4 months ago

I think the final conclusion about #1274 was to make the basic authentication the same as the current non-docker situation. But it's a bit ambiguous because I did strike-trough of "Some parts should be always accessible", because it's already the current non-docker batch situation.

$ curl 'https://{,dev.,dev-docker.}batch.internet.nl/site/a/1/' -sSw '%{http_code}\t%{url_effective}\n' -o/dev/null
302 https://batch.internet.nl/site/a/1/
302 https://dev.batch.internet.nl/site/a/1/
401 https://dev-docker.batch.internet.nl/site/a/1/
mxsasha commented 4 months ago

Note that dev-docker.batch has the branch for #1274 currently deployed, so displays the behaviour that we thought we wanted in #1274, but have now found not to work. So dev-docker.batch does not reflect current main branch. Your curl is intentional expected behaviour in the original #1274 requirements. Let's make sure we have all details pinned down in that issue.

mxsasha commented 3 months ago

Closed through #1274