search

internetstandards / Internet.nl

Internet standards compliance test suite
https://internet.nl
166 stars 36 forks source link

Limit TTL #1340

Open bwbroersma opened 4 months ago

bwbroersma commented 4 months ago

@janwillemstegink had an idea to limit the TTL, I said this was already done: https://github.com/internetstandards/Internet.nl/blob/d3abfb56bfb63d8dde6523a395fe168cdd331705/docker/resolver/resolver-permissive.conf.template#L15-L16 But these are not yet deployed in v1.8.5, I tested a domain with a TTL record of a week, and it's indeed still cached. Fixed with https://github.com/internetstandards/Internet.nl/pull/1292/commits/47fa82199eec75ef9328b17a77e883e2df44c52e from merge:

Close this issue if it's deployed?

bwbroersma commented 3 months ago

@mxsasha: I see the TTL is both set as context and in a config file? The code settings seems redundant to the unbound conf? https://github.com/internetstandards/Internet.nl/blob/c025ade5aaad177322690631e5e1bfa965daff2f/checks/tasks/__init__.py#L40-L41 What should I now see on v1.8.5 single-test? Since it seems higher than the max caching of 200 * 0.9: https://github.com/internetstandards/Internet.nl/blob/c025ade5aaad177322690631e5e1bfa965daff2f/internetnl/settings.py#L260

BTW shouldn't this move to the unbound conf too? https://github.com/internetstandards/Internet.nl/blob/c025ade5aaad177322690631e5e1bfa965daff2f/checks/tasks/__init__.py#L45