Add notes on INTERNETNL_CACHE_TTL on batch

internetstandards / Internet.nl

Internet standards compliance test suite

https://internet.nl

164 stars 36 forks source link

Add notes on INTERNETNL_CACHE_TTL on batch #1359

Closed mxsasha closed 3 months ago

mxsasha commented 3 months ago

Review of the use of CACHE_TTL suggests it is safe to change this. On single test, there are many side effects, and it should stay as is.

baknu commented 3 months ago

@mxsasha Good thing we have notes on this now. Still have some questions:

Could we recommend an INTERNETNL_CACHE_TTL value for batch? What is the value of INTERNETNL_CACHE_TTL on the current pre-Docker batch (PROD and DEV)?
And could we have this recommended value set by ENABLE_BATCH?

mxsasha commented 3 months ago

* Could we recommend an `INTERNETNL_CACHE_TTL` value for batch?  What is the value of `INTERNETNL_CACHE_TTL` on the current pre-Docker batch (PROD and DEV)?

We kept the 200 second default value in non-docker batch. I just set it to 1 hour on dev and future-prod docker.

* And could we have this recommended value set by `ENABLE_BATCH`?

Due to its impact, maybe it is best as a separate setting for now.