internetstandards / Internet.nl

Internet standards compliance test suite
https://internet.nl
171 stars 35 forks source link

Feedback solved in new designs Internet.nl #1477

Open JasperKoopmanschap opened 1 month ago

JasperKoopmanschap commented 1 month ago

Goodmorning everybody,

Hereby the new designs of the website. We discussed somethings in the meeting last Thursday, what I didn't resolved yet. I look forward to the feedback so we can wrap it up and make the designs final!

Desktop:

D1 0 - Homepage D1 1 - Homepage Sticky D1 2 - Test e-mail D1 2 - Test verbinding D1 3 - Laadscherm D1 3 - Test website D1 4 - Test tools D2 0 - Kennisbank D2 1 - Kennisbank Detail D3 0 - Nieuws D3 1 - Nieuws Detail D4 0 - Over ons D5 0 - Hall of Fame D6 0 - Service   Contact

Mobile:

M1 0 - Homepage M1 2 - Test e-mail M1 2 - Test verbinding M1 3 - Test tools M1 3 - Test website M1 4 - Test tools-1 M1 4 - Test tools M2 0 - Kennisbank M2 1 - Kennisbank Detail M3 0 - Nieuws M3 1 - Nieuws Detail M4 0 - Over ons M5 0 - Hall of Fame M6 0 - Service   Contact
baknu commented 3 weeks ago

These designs are part of Website Redesign issue https://github.com/internetstandards/Internet.nl/issues/1252

Feedback on previous version: https://github.com/internetstandards/Internet.nl/issues/1460#issuecomment-2230424868


Joint feedback (under construction)

General

Desktop

Mobile

mxsasha commented 3 weeks ago

While it's great to use github for openness, I'm starting to see github issues are an awful platform for these kind of reviews. This is 80 pages of content, there is no way we will review this accurately, also because all coherence between pages is lost. If we want more design iterations, we should find a more appropriate platform, even if it is not open.

That said, I think this is looking good, and have only one comment: I don't think we should have modal overlay that appears while the test is running (the window with spinners with a dimmed out website on the background). It looks good, and seems sensible, but will lead to one of two situations:

The waiting-for-test-results experience should therefore be on a separate page.

Also, just keeping a note: we really wanted to improve the spacing for the tech table, in width, but we haven't improved on that at all. It's much too cramped now.