Improve alerting - Githubissues

internetstandards / Internet.nl

Internet standards compliance test suite

https://internet.nl

177 stars 37 forks source link

Improve alerting #1507

Closed aequitas closed 3 weeks ago

aequitas commented 1 month ago

don't alert on a single probe domain failing
change default text to english
add additional domains for testing, also ones with mail server (internetsociety.org, ripe.net, surf.nl, ecp.nl, forumstandaardisatie.nl en rijksoverheid.nl

bwbroersma commented 1 month ago

$ dig +noall +answer forumstandaardisatie.nl MX rijksoverheid.nl MX
forumstandaardisatie.nl. 14400  IN      MX      10 mail.ssonet.nl.
forumstandaardisatie.nl. 14400  IN      MX      10 mail2.ssonet.nl.
rijksoverheid.nl.       14400   IN      MX      10 mail.ssonet.nl.
rijksoverheid.nl.       14400   IN      MX      10 mail2.ssonet.nl.

So I would only pick one of the two, since otherwise it's actually (almost) the same test, same MX and same name servers:

$ dig +noall +answer forumstandaardisatie.nl SOA rijksoverheid.nl SOA
forumstandaardisatie.nl. 14400  IN      SOA     ns1.rijksoverheidnl.nl. domeinnaam.minaz.nl. 2024091201 14400 7200 1209600 86400
rijksoverheid.nl.       14400   IN      SOA     ns1.rijksoverheidnl.nl. domeinnaam.minaz.nl. 2024091201 14400 7200 1209600 86400

baknu commented 1 month ago

Ok, let's add minez.nl and skip rijksoverheid.nl.

aequitas commented 1 month ago

minez.nl fails on the mail test due to timing out on tls probe: https://dev-docker.internet.nl/mail/minez.nl/ but it does seem that the probe creates a result: https://dev-docker.internet.nl/mail/minez.nl/results so maybe there is an bug where the probe does not get marked 'done' once completed?

bwbroersma commented 1 month ago

@aequitas see the end of point 2 in https://github.com/internetstandards/Internet.nl/issues/1425#issuecomment-2143818855, I think it's related (BTW the correct URL is https://dev-docker.internet.nl/mail/minez.nl/results).

aequitas commented 1 month ago

I'll leave minez.nl out of the mail tests for now then until we switch to ssllyze

aequitas commented 1 month ago

https://github.com/internetstandards/Internet.nl/pull/1508