search

internxt / drive-desktop

https://internxt.com/drive
GNU Affero General Public License v3.0
168 stars 21 forks source link

[PB-680](fix): Exlude native OS files #297

Closed PixoDev closed 1 year ago

PixoDev commented 1 year ago

Exclude files from being created mostly

JoanVicens commented 1 year ago

The validation should also be added on FilePath.ts to ensure all paths are valid since users could already have that file on their drive. This way we can catch it whenever it appears and it also allows for being tested.

Edit: in the cases the file is being retrieved it would fail on the WebdavUnknownItemTypeSearcher since the path will not be valid and only an error mapping would be needed. The only case it needs validation in the controller is on the _create "controller"

PixoDev commented 1 year ago

I don't know If I understood you, but updated the PR, let me know if that's what you mean @JoanVicens

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication