search

internxt / drive-desktop

https://internxt.com/drive
GNU Affero General Public License v3.0
168 stars 21 forks source link

[_] feat: block deletion until is finished #351

Closed JoanVicens closed 1 year ago

JoanVicens commented 1 year ago

Integrates the changes on https://github.com/internxt/node-win/pull/4

Uses the notifyDeleteCallback instead of the notifyDeleteCompletionCallback so until trueis returned Windows doesn´t remove the file from the explorer.

Also adds FileFinderByContentsId to encapsulate find file logic as will be needed in more places

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

JoanVicens commented 1 year ago

@cg27shokworks When the notifyDeleteCallback executes I get 

status: 0
Error in CfExecute().
Error in CfExecute(), HRESULT: 8007018e
status: 0
Error in CfExecute().