internxt / drive-desktop

https://internxt.com/drive
GNU Affero General Public License v3.0
168 stars 21 forks source link

[_] fix: app crashes loading the localhost #364

Closed JoanVicens closed 1 year ago

JoanVicens commented 1 year ago

ℹ️ This PR needs the changes on https://github.com/internxt/node-win/pull/14

Problem After logging out and logging back in or starting the app without being logged and login in crashes the app.

Why Found out that when we close all windows the local server that serves the UI closes and then when we create another window it cannot load the page making the app crash

Solution On the USER_LOGGED_IN event I changed the order of the creation of the widget window and the deletion of the auth window.

Side effects As of now, we can log out and back in without the app crashing during the testing found out that we were not closing the background process correctly. Also solved in this pr

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication