interpreting-rl-behavior / interpreting-rl-behavior.github.io

Code for the site https://interpreting-rl-behavior.github.io/
Creative Commons Attribution 4.0 International
0 stars 0 forks source link

Identify why the image never goes black when using both sim actions and sim images #40

Closed leesharkey closed 2 years ago

leesharkey commented 2 years ago

Examples of where it should clearly go black https://user-images.githubusercontent.com/7349481/144333903-706e186f-c28f-4371-ad94-95cfcc7d989f.mp4

https://user-images.githubusercontent.com/7349481/144333941-21a2853e-5265-402b-94ed-23cddb31b3df.mp4

https://user-images.githubusercontent.com/7349481/144333990-e7ab07bc-4aef-4130-ac9b-22da8ad2a2f9.mp4

leesharkey commented 2 years ago

but see this one from rssm9, sim acts 65000. Maybe we just need to wait for training to go on longer. https://user-images.githubusercontent.com/7349481/144388176-21c811fc-e34b-4a0b-a7a5-28aea378987e.mp4

leesharkey commented 2 years ago

Fixed by aligning all the done/hx/black images appropriately in the recordings & train_loader etc.

Done in f7843f216e4cf713c8430122cddca1aded4f147b but maybe also in some later commits