search

interpreting-rl-behavior / interpreting-rl-behavior.github.io

Code for the site https://interpreting-rl-behavior.github.io/
Creative Commons Attribution 4.0 International
0 stars 0 forks source link

Remedy the unexpected broadcasting behaviour for extrema-finding code in import_data.py #65

Closed leesharkey closed 2 years ago

danbraunai commented 2 years ago

I think you said this is resolved?

leesharkey commented 2 years ago

Was waiting to confirm by checking whether the samples that the code identified really were extrema on the bar charts.

Confirmed, though I needed to change the dataset from which the extrema values were being calculated (done in 12679dd6a9bb54c36eef09fc5a981b86afb9beb7 ). The issue was that the extrema for the generated dataset and the real dataset were different. This caused issues like IC2 having no extrema that surpassed the threshold from the other dataset. Now with the extrema values and extrema samples being calculated on the same dataset, every IC has extrema samples.