search

interscript / interscript-ruby

Interoperable script conversion systems (ISCS) with the `interscript` gem
Other
11 stars 30 forks source link

Fix CI/CD workflow #585

Closed webdev778 closed 3 years ago

webdev778 commented 3 years ago

Fix #584

ronaldtse commented 3 years ago

@webdev778 what is the reason for 'Revert "Run tests in parallel"' commit?

It seems that the parallel tests sometimes cause sequitur tests to fail (even though sequitur often fails on other reasons). Not sure...

ronaldtse commented 3 years ago

Not sure why but Windows is failing:

https://github.com/interscript/interscript/pull/585/checks?check_run_id=1291551321

webdev778 commented 3 years ago

@webdev778 what is the reason for 'Revert "Run tests in parallel"' commit?

sorry for my late reply. as you can see, the total number of test cases was wrong from "parallel_split_test" gem. image

I think it may be due to something like tests loading being non-deterministic. I assume it's something like a test gets defined twice and then the parallel thing can get messed up and it doesn't know which test to execute.

I fixed it, please refer #587