search

interscript / interscript-ruby

Interoperable script conversion systems (ISCS) with the `interscript` gem
Other
11 stars 30 forks source link

Question to @bilashsaha #692

Closed webdev778 closed 3 years ago

webdev778 commented 3 years ago

there are a lot of maps written like this - pattern: ([ක]=?)(?=[\u0dcf\u0dd0\u0dd1\u0dd2\u0dd3\u0dd4\u0dd6\u0dd8\u0df2\u0dd9\u0dda\u0ddb\u0ddc\u0ddd\u0dde\u0dca]) result: 'k'

of course, it works. ([ක]=?)(?=[\u0dcf\u0dd0\u0dd1\u0dd2\u0dd3\u0dd4\u0dd6\u0dd8\u0df2\u0dd9\u0dda\u0ddb\u0ddc\u0ddd\u0dde\u0dca]) this syntax can be simplified to ක(?=[\u0dcf\u0dd0\u0dd1\u0dd2\u0dd3\u0dd4\u0dd6\u0dd8\u0df2\u0dd9\u0dda\u0ddb\u0ddc\u0ddd\u0dde\u0dca])

I just wonder if it was your intention, but I'm 100% sure it wasn't though. I'd appreciate your clarification.

ping @bilashsaha

ronaldtse commented 3 years ago

@bilashsaha just wondering if the rule can be simplified as proposed. Thanks!

bilashsaha commented 3 years ago

@webdev778 You are right. I did not have a second look at these codes. I will take care of these.