search

interscript / interscript-ruby

Interoperable script conversion systems (ISCS) with the `interscript` gem
Other
11 stars 30 forks source link

V2.4 #745

Closed webdev778 closed 2 years ago

webdev778 commented 3 years ago

Interdependent PRs: interscript/interscript-js#24, interscript/maps#21

As things are intermingled due to complexity of changes, I will explain what happened in this PR, but we will also have to merge two other PRs for the other repos. The tests will fail - this is all expected and correct. We need to accept all PRs.

Separate the js/maps submodules

This commit fixes: #726 We introduced a new repository: interscript/interscript-bootstrap which takes a role of interscript/interscript regarding "submodules" which we no longer use, but we replace it with a bootstrap script. Due to the architecture, all repos are interdependent. The Ruby version expects the JS version to be in ../js directory, maps in ../maps. JS expects the Ruby to be in ../ruby.

The migration plan No.1

This is what I recommend. Before merging it all, we may rename interscript/interscript to interscript/interscript-ruby and interscript/interscript-bootstrap to interscript/interscript then ensure it gets corrected in all CI scripts.

The developers will pull their interscript and they will just simply need to run ./bootstrap.sh to get it all running

The migration plan No.2

Do nothing, keep the repositories as they are. Developers will need to clone the bootstrap repository and continue from there.

Ensure that interscript.org takes README.adoc from interscript/interscript-bootstrap

Post-deployment

We will need to remove the v2.4 branch. We may restore it when v2.5 release happens and we want to do a longer term support for v2.4 components.

Independent releases

This commit fixes: #727, interscript/interscript-js#22, interscript/interscript-js#23

Patch releases (eg. v2.4.1) are now independent across all 3 repositories. Minor releases will (eg. a bump to v2.5) will require a little bit of care due to the interdependency problem. Things are documented in https://github.com/interscript/interscript.org/blob/master/docs/Maintainers.adoc

ronaldtse commented 3 years ago

Agree with migration plan 1, where interscript ruby will have its own interpreter home. In this case we should instead move “interscript” to “interscript-ruby” and create a new “interscript” repo.