search

interscript / maps

Script conversion maps for Interscript
2 stars 1 forks source link

Maps lacking tests #163

Open webdev778 opened 3 years ago

webdev778 commented 3 years ago

We are in the process of porting the maps to interscript/lcs. The problem is, some maps lack tests. Below is a list of maps and their git history so we can see better who made them and contact them to provide those tests possibly.

alalc-bul-Cyrl-Latn-1997

Alexande B (1):

Ronald Tse (2):

alalc-ukr-Cyrl-Latn-2011

Andrei Kislichenko (1):

Ronald Tse (1):

bgnpcgn-arm-Armn-Latn-1981

Ronald Tse (5):

bgnpcgn-ell-Grek-Latn-1996

Nick Nicholas (4):

Ronald Tse (2):

webdev778 (1):

bgnpcgn-fas-Arab-Latn-1956

Ronald Tse (4):

webdev778 (1):

bgnpcgn-zho-Hans-Latn-1979

Ronald Tse (5):

elot-ell-Grek-Latn-743-2001-tl

Nick Nicholas (7):

Ronald Tse (2):

webdev778 (1):

icao-bul-Cyrl-Latn-9303

Ronald Tse (5):

webdev778 (1):

icao-fas-Arab-Latn-9303

Andrei Kislichenko (1):

Ronald Tse (5):

webdev778 (1):

icao-heb-Hebr-Latn-9303

Andrei Kislichenko (1):

Ronald Tse (5):

icao-mkd-Cyrl-Latn-9303

Ronald Tse (5):

icao-rus-Cyrl-Latn-9303

Ronald Tse (7):

webdev778 (1):

icao-srp-Cyrl-Latn-9303

Ronald Tse (5):

icao-ukr-Cyrl-Latn-9303

Ronald Tse (5):

webdev778 (1):

iso-rus-Cyrl-Latn-9-1995

Ronald Tse (8):

webdev778 (1):

un-ell-Grek-Latn-1987-ts

Nick Nicholas (5):

Ronald Tse (2):

webdev778 (1):

webdev778 commented 3 years ago

Some pings: @andrew2net @CAMOBAP @opoudjis

CAMOBAP commented 3 years ago

@webdev778 I always added tests for mappings that contain any samples. In case if there are no samples, I tried to find/google. I decided to not generate the test on my own because this is a bad approach IMHO because if implementation contains bugs/issues we will just 'support' those issues with tests. Let me know if you disagree (I'm open to change my mind).

webdev778 commented 3 years ago

@CAMOBAP As far as I can see, there's only 1 map of yours on this list. I used an approach to sometimes generate my own tests based on what's described in the notes. This ensures that the notes are implemented correctly.

andrew2net commented 3 years ago

@webdev778 I've added tests whenever I was able to do it. Unfortunately, I'm not good in all languages for that I've implemented maps (some of the languages I don't know at all). Try to ask @ronaldtse, he had an intention to find experts.

opoudjis commented 3 years ago

If you do need tests, just copy paste them from the parent mappings.

ronaldtse commented 3 years ago

If you do need tests, just copy paste them from the parent mappings.

@webdev778 can you help copy those tests for the Greek maps? Thanks.

if implementation contains bugs/issues we will just 'support' those issues with tests. Let me know if you disagree (I'm open to change my mind).

@CAMOBAP still we would like to encode some tests because we are switching to a new language mapping approach, we need to ensure the new output is identical to old output.

icao-fas-Arab-Latn-9303 @AhMohsen46 can you help create the tests?

icao-rus-Cyrl-Latn-9303 @CAMOBAP can you do this?

icao-ukr-Cyrl-Latn-9303 alalc-ukr-Cyrl-Latn-2011 @ni4 would you be able to help?

icao-mkd-Cyrl-Latn-9303 icao-srp-Cyrl-Latn-9303 @andrew2net I believe you can make tests for these?

ni4 commented 3 years ago

@ronaldtse Sure. At first glance icao-ukr-Cyrl-Latn-9303 has some extra symbols, which are not present in Ukrainian, and doesn't include some rules (like, when some letter is first in the word then it is transliterated with 2 symbols instead of 1). I assume that I should fix these things as well?

AhMohsen46 commented 3 years ago

working on this: icao-fas-Arab-Latn-9303 now, will push it in an hour at max