interscript / rababa

Rababa, the diacritization library for Arabic and Hebrew (Abjad scripts in general)
12 stars 1 forks source link

Audit Ruby Code #40

Closed webdev778 closed 2 years ago

ronaldtse commented 3 years ago

Thanks @webdev778, this is definitely in the right direction, and more refactoring in this direction would be better.

Any particular reason for the test failures?

gilgameshjw commented 3 years ago

merging after audit/refactoring

ronaldtse commented 3 years ago

@webdev778 can we merge this soon? Thanks.

webdev778 commented 2 years ago

Superseded by #43